Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates cache value for NuGet shield #340

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Updates cache value for NuGet shield #340

merged 1 commit into from
Nov 25, 2019

Conversation

danielwertheim
Copy link
Contributor

maxAge is deprecated (still supported) and replaced with cacheSeconds

Reducing to 3600s (1h) as 2592000s seem a bit high. Default is 300s

maxAge is deprecated (still supported) and replaced with cacheSeconds
Reducing to 1h
@watfordgnf watfordgnf merged commit c6ec545 into master Nov 25, 2019
@watfordgnf
Copy link
Collaborator

@danielwertheim unrelated issue seen at CI time:

##[section]Starting: IntegrationTests .Net4.5.2
==============================================================================
Task         : .NET Core
Description  : Build, test, package, or publish a dotnet application, or run a custom dotnet command
Version      : 2.158.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/build/dotnet-core-cli
==============================================================================
[command]C:\windows\system32\chcp.com 65001
Active code page: 65001
[command]"C:\Program Files\dotnet\dotnet.exe" test d:\a\1\s\src\Tests\IntegrationTests\IntegrationTests.csproj --logger trx --results-directory d:\a\_temp -c Release -f net452 --no-build
Test run for d:\a\1\s\src\Tests\IntegrationTests\bin\Release\net452\IntegrationTests.dll(.NETFramework,Version=v4.5.2)
Microsoft (R) Test Execution Command Line Tool Version 16.3.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:09.16]     IntegrationTests.TestConnectionSecurity.TestJwtFunctionality [SKIP]
  ! IntegrationTests.TestConnectionSecurity.TestJwtFunctionality [1ms]
[xUnit.net 00:00:16.51]     IntegrationTests.TestConnection.TestCallbacksOrder [SKIP]
  ! IntegrationTests.TestConnection.TestCallbacksOrder [1ms]
[xUnit.net 00:00:40.06]     IntegrationTests.TestBasic.TestRequestSafetyWithTasks [SKIP]
  ! IntegrationTests.TestBasic.TestRequestSafetyWithTasks [1ms]
[xUnit.net 00:00:56.27]     IntegrationTests.TestCluster.TestPingReconnect [SKIP]
  ! IntegrationTests.TestCluster.TestPingReconnect [1ms]
[xUnit.net 00:01:25.60]     IntegrationTests.TestCluster.TestHotSpotReconnect [SKIP]
  ! IntegrationTests.TestCluster.TestHotSpotReconnect [1ms]
[xUnit.net 00:01:35.76]     IntegrationTests.TestConnectionDrain.TestDrainBlocking [FAIL]
  X IntegrationTests.TestConnectionDrain.TestDrainBlocking [1s 140ms]
  Error Message:
   Assert.True() Failure
Expected: True
Actual:   False
  Stack Trace:
     at IntegrationTests.TestConnectionDrain.TestDrainBlocking() in d:\a\1\s\src\Tests\IntegrationTests\TestConnection.cs:line 983
[xUnit.net 00:02:41.63]     IntegrationTests.TestBasic.TestRequestSafetyWithTasks_OldRequestStyle [SKIP]
  ! IntegrationTests.TestBasic.TestRequestSafetyWithTasks_OldRequestStyle [1ms]
Results File: d:\a\_temp\VssAdministrator_fv-az483_2019-11-25_15_21_06.trx
Test Run Failed.

Total tests: 159
     Passed: 152
     Failed: 1
    Skipped: 6
 Total time: 2.7486 Minutes
##[error]Error: The process 'C:\Program Files\dotnet\dotnet.exe' failed with exit code 1
##[error]Dotnet command failed with non-zero exit code on the following projects : d:\a\1\s\src\Tests\IntegrationTests\IntegrationTests.csproj
##[section]Async Command Start: Publish test results
Publishing test results to test run '1252'.
TestResults To Publish 159, Test run id:1252
Test results publishing 159, remaining: 0. Test run id: 1252
Published Test Run : https://dev.azure.com/NATS-CI/NATS-CI/_TestManagement/Runs?runId=1252&_a=runCharts.
##[section]Async Command End: Publish test results
##[section]Finishing: IntegrationTests .Net4.5.2

@danielwertheim
Copy link
Contributor Author

Yes. That is one of the flaky tests. Up for fixing it? 😉

@watfordgnf
Copy link
Collaborator

I've been following along "at home," so to speak, and have troubles replicating that one locally.

@danielwertheim danielwertheim deleted the fix-nuget-badge branch November 26, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants